This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Conversation
Codecov Report
@@ Coverage Diff @@
## master #902 +/- ##
==========================================
+ Coverage 57.94% 58.61% +0.66%
==========================================
Files 218 218
Lines 15365 15366 +1
Branches 2146 2103 -43
==========================================
+ Hits 8904 9007 +103
+ Misses 5879 5812 -67
+ Partials 582 547 -35
Continue to review full report at Codecov.
|
vishwacsena
approved these changes
Jul 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #886 to resolve the issue that id mismatched in multi turn prompts when merging multiple qna files. The fix is to use lu/qna merger to merge multiple qna files and resolve the follow up ids as a whole instead of resolving each file first and then directly merging them. It also fixed an issue in crosstrain that will have negetive impact for the id matching flow, that means I added the source
> !# @qna.pair.source = crosstrainedfor all crosstrained DeferToRecognizer_LUIS_{dialogName} QA pair. Then I filtered out such pairs when resolving the multi turn prompt ids to make sure the follow up turns always point to the right original QA pairs. The reason I did this is that, some orginial questions will be added to crosstrained DeferToRecognizer_LUIS_{dialogName}, when resolving the follow up prompt ids, it may point to crosstrained DeferToRecognizer_LUIS_{dialogName} QA pair. This is unreasonable.Unit test is added here