This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Improve the CRUD performance of LU sections#901
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #901 +/- ##
==========================================
+ Coverage 57.25% 57.45% +0.20%
==========================================
Files 218 220 +2
Lines 16237 16269 +32
Branches 2251 2241 -10
==========================================
+ Hits 9296 9347 +51
+ Misses 6362 6352 -10
+ Partials 579 570 -9
Continue to review full report at Codecov.
|
feich-ms
reviewed
Jul 17, 2020
feich-ms
reviewed
Jul 17, 2020
feich-ms
reviewed
Jul 17, 2020
feich-ms
reviewed
Jul 17, 2020
…framework-cli into hond/luparser-perf
feich-ms
reviewed
Jul 17, 2020
feich-ms
reviewed
Jul 17, 2020
feich-ms
approved these changes
Jul 17, 2020
Contributor
|
@lei9444 please verify the functionality and efficiency of this improvments in composer side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #888
Improve the performance for adding/updating/deleting/inserting section into LUResource.
What this pr did:
what will do
what should be discussed
Currently, LU has no static checker. So, if someone updates a section, the diagnostic of the original section should be removed.
The issue is, it is hard to locate the original errors, for many of them do not contain the range info.
Welcome to propose a solution.
performance improvement