Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Comments

enable to configure luis publishing slot enviroment#898

Merged
munozemilio merged 1 commit intomasterfrom
feich/enableConfigLUISSlot
Jul 16, 2020
Merged

enable to configure luis publishing slot enviroment#898
munozemilio merged 1 commit intomasterfrom
feich/enableConfigLUISSlot

Conversation

@feich-ms
Copy link
Contributor

@feich-ms feich-ms commented Jul 15, 2020

fix #855 to enable users to configure the publishing slot enviroment. Before this change, lu build will default publish to production slot with no configuration capability. After the fix, users can specify --isStaging in lu:build to publish to staging slot. Default to production slot if not specified.

@boydc2014
Copy link
Contributor

I know the issue is described in #855, but it would be good to summarize what this PR actually did for better review transpancy

@codecov-commenter
Copy link

Codecov Report

Merging #898 into master will decrease coverage by 0.22%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #898      +/-   ##
==========================================
- Coverage   57.94%   57.72%   -0.23%     
==========================================
  Files         218      217       -1     
  Lines       15365    15150     -215     
  Branches     2146     2119      -27     
==========================================
- Hits         8904     8745     -159     
+ Misses       5879     5844      -35     
+ Partials      582      561      -21     
Impacted Files Coverage Δ
packages/lu/src/parser/lubuild/builder.ts 12.80% <0.00%> (ø)
packages/lu/src/parser/lubuild/core.ts 16.29% <ø> (ø)
packages/qnamaker/src/commands/qnamaker/build.ts 76.84% <ø> (ø)
packages/luis/src/commands/luis/build.ts 80.00% <100.00%> (ø)
packages/lg/src/commands/lg/index.ts 66.66% <0.00%> (-16.67%) ⬇️
packages/luis/src/commands/luis/index.ts 66.66% <0.00%> (-16.67%) ⬇️
...kages/luis/src/commands/luis/application/delete.ts 71.42% <0.00%> (-4.58%) ⬇️
...kages/luis/src/commands/luis/application/import.ts 53.84% <0.00%> (-1.06%) ⬇️
packages/luis/src/api/http-request.ts 86.66% <0.00%> (-0.84%) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 547c305...8212c5e. Read the comment docs.

@munozemilio munozemilio merged commit d3cbcf0 into master Jul 16, 2020
@munozemilio munozemilio deleted the feich/enableConfigLUISSlot branch July 16, 2020 00:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MCS-DE-GO] -- allow configuring the LUIS slot on lubuild.Builder publish application

4 participants