This repository was archived by the owner on Jan 15, 2025. It is now read-only.
enable to configure luis publishing slot enviroment#898
Merged
munozemilio merged 1 commit intomasterfrom Jul 16, 2020
Merged
Conversation
Contributor
|
I know the issue is described in #855, but it would be good to summarize what this PR actually did for better review transpancy |
Codecov Report
@@ Coverage Diff @@
## master #898 +/- ##
==========================================
- Coverage 57.94% 57.72% -0.23%
==========================================
Files 218 217 -1
Lines 15365 15150 -215
Branches 2146 2119 -27
==========================================
- Hits 8904 8745 -159
+ Misses 5879 5844 -35
+ Partials 582 561 -21
Continue to review full report at Codecov.
|
munozemilio
approved these changes
Jul 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #855 to enable users to configure the publishing slot enviroment. Before this change, lu build will default publish to production slot with no configuration capability. After the fix, users can specify --isStaging in lu:build to publish to staging slot. Default to production slot if not specified.