Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Comments

CRUD optimizations for qna sections#854

Merged
feich-ms merged 10 commits intomasterfrom
feich/supportCRUDForQnASection
Jun 30, 2020
Merged

CRUD optimizations for qna sections#854
feich-ms merged 10 commits intomasterfrom
feich/supportCRUDForQnASection

Conversation

@feich-ms
Copy link
Contributor

@feich-ms feich-ms commented Jun 12, 2020

Optimize CRUD operations for qna sections which will be consumed by composer qna editor.

@feich-ms feich-ms changed the title support qna section CRUD CRUD optimizations for qna sections Jun 12, 2020
@feich-ms feich-ms marked this pull request as ready for review June 12, 2020 08:33
@feich-ms feich-ms requested a review from munozemilio as a code owner June 12, 2020 08:33
@liweitian
Copy link

Found some problems on it. Need to discuss with @feich-ms . Do not merge it at this time.

@feich-ms feich-ms changed the title CRUD optimizations for qna sections [Do not merge]CRUD optimizations for qna sections Jun 18, 2020
@feich-ms feich-ms changed the title [Do not merge]CRUD optimizations for qna sections CRUD optimizations for qna sections Jun 30, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #854 into master will decrease coverage by 0.69%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #854      +/-   ##
==========================================
- Coverage   58.01%   57.31%   -0.70%     
==========================================
  Files         214      214              
  Lines       15368    14972     -396     
  Branches     2055     2078      +23     
==========================================
- Hits         8915     8581     -334     
+ Misses       5908     5830      -78     
- Partials      545      561      +16     
Impacted Files Coverage Δ
packages/lu/src/parser/lufile/luParser.js 89.51% <75.00%> (-1.77%) ⬇️
packages/lu/src/parser/lufile/qnaSection.js 89.47% <75.00%> (-1.12%) ⬇️
packages/lu/src/parser/lufile/sectionOperator.js 90.00% <83.33%> (+1.42%) ⬆️
packages/lu/src/parser/cross-train/crossTrainer.js 94.71% <100.00%> (+2.40%) ⬆️
packages/lu/src/parser/lufile/parseFileContents.js 80.54% <100.00%> (-1.07%) ⬇️
...mathematics/confusion_matrix/AppConfusionMatrix.ts 6.66% <0.00%> (-22.32%) ⬇️
...kages/luis/src/commands/luis/application/create.ts 61.11% <0.00%> (-19.85%) ⬇️
...rc/commands/luis/application/assignazureaccount.ts 82.60% <0.00%> (-17.40%) ⬇️
...ackages/luis/src/commands/luis/application/list.ts 84.61% <0.00%> (-15.39%) ⬇️
...ckages/luis/src/commands/luis/application/query.ts 73.33% <0.00%> (-14.17%) ⬇️
... and 84 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86f0302...e115d34. Read the comment docs.

@feich-ms feich-ms merged commit 3323a48 into master Jun 30, 2020
@feich-ms feich-ms deleted the feich/supportCRUDForQnASection branch June 30, 2020 02:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants