This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Conversation
Codecov Report
@@ Coverage Diff @@
## master #852 +/- ##
==========================================
+ Coverage 57.90% 58.69% +0.78%
==========================================
Files 218 217 -1
Lines 15364 15619 +255
Branches 2060 2131 +71
==========================================
+ Hits 8897 9167 +270
+ Misses 5919 5884 -35
- Partials 548 568 +20
Continue to review full report at Codecov.
|
added 8 commits
July 11, 2020 12:30
Upgrade json-ptr to 1.3 Full uischema test examples.
added 9 commits
July 14, 2020 12:17
munozemilio
reviewed
Jul 14, 2020
| * [`bf dialog`](#bf-dialog) | ||
| * [`bf dialog:merge PATTERNS`](#bf-dialogmerge-patterns) | ||
| * [`bf dialog:verify PATTERNS`](#bf-dialogverify-patterns) | ||
| - [@microsoft/bf-dialog](#microsoftbf-dialog) |
Contributor
There was a problem hiding this comment.
This should be outside the commands toc otherwise it will be deleted on the next documentation autogen
Author
There was a problem hiding this comment.
I did auto-gen and then restored things from the original. For example the slashes for code references are still the wrong way.
munozemilio
approved these changes
Jul 15, 2020
Contributor
munozemilio
left a comment
There was a problem hiding this comment.
Some details you may want to take care before merge
packages/dialog/README.md
Outdated
| ``` | ||
|
|
||
| _See code: [src/commands/dialog/index.ts](https://github.com/microsoft/botframework-cli/tree/master/packages/dialog/src/commands/dialog/index.ts)_ | ||
| _See code: [src/commands/dialog/index.ts](https://github.com/microsoft/botframework-cli/tree/master/packages/dialog/blob/v1.0.0/src/commands/dialog/index.ts)_ |
packages/dialog/README.md
Outdated
| ``` | ||
|
|
||
| _See code: [src/commands/dialog/merge.ts](https://github.com/microsoft/botframework-cli/tree/master/packages/dialog/src/commands/dialog/merge.ts)_ | ||
| _See code: [src/commands/dialog/merge.ts](https://github.com/microsoft/botframework-cli/tree/master/packages/dialog/blob/v1.0.0/src/commands/dialog/merge.ts)_ |
added 2 commits
July 14, 2020 17:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds to dialog:merge the ability to merge .uischema files to implement #852 .
To do this it walks-over the component (.csproj, package.json, .nuspec, nuget, packages.config) tree and builds a breadth-first parent before child order to use for when merging .uischema definitions. The uischema files are checked to ensure they are valid according to the uischema definition and to ensure that all properties are found in the schema. The result is a merged ui schema file per locale like [.locale].uischema.
It will also do an analysis and show errors in content files of:
Also added the ability to infer the output file name from the first project.
NOTE: I did keep the ability to do .schema files directly as patterns. This is mainly for testing.