Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Comments

Publish cobertura code coverage to codecov.io#850

Merged
munozemilio merged 52 commits intomasterfrom
v-bruhal/coveralls5-20
Jun 29, 2020
Merged

Publish cobertura code coverage to codecov.io#850
munozemilio merged 52 commits intomasterfrom
v-bruhal/coveralls5-20

Conversation

@BruceHaley
Copy link
Contributor

@BruceHaley BruceHaley commented Jun 10, 2020

Build 138822 published code coverage results to codecov.io here.
I think you will find these numbers match your local numbers.

@BruceHaley BruceHaley requested a review from cleemullins as a code owner June 10, 2020 02:06
@BruceHaley BruceHaley linked an issue Jun 10, 2020 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@5e319ae). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #850   +/-   ##
=========================================
  Coverage          ?   57.15%           
=========================================
  Files             ?      213           
  Lines             ?    14957           
  Branches          ?     2077           
=========================================
  Hits              ?     8548           
  Misses            ?     5851           
  Partials          ?      558           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e319ae...f502157. Read the comment docs.

@BruceHaley BruceHaley changed the title Publish cobertura code coverage to codecov Publish cobertura code coverage to codecov.io Jun 10, 2020
Copy link
Contributor

@munozemilio munozemilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we adding nock?

@BruceHaley
Copy link
Contributor Author

Why are we adding nock?
Good question. nock removed.

@BruceHaley
Copy link
Contributor Author

BruceHaley commented Jun 26, 2020

Why are we adding nock?
Good question. nock removed.

Reverted. Removing nock got this:

nyc npm run test

@microsoft/bf-lu@1.0.0 test D:\a\1\s\packages\lu
mocha

Error: Cannot find module 'nock'
Require stack:

  • D:\a\1\s\packages\lu\test\commands\luis\translate.test.ts
  • D:\a\1\s\common\temp\node_modules.pnpm\registry.npmjs.org\mocha\6.2.2\node_modules\mocha\lib\mocha.js
  • D:\a\1\s\common\temp\node_modules.pnpm\registry.npmjs.org\mocha\6.2.2\node_modules\mocha\lib\cli\one-and-dones.js
  • D:\a\1\s\common\temp\node_modules.pnpm\registry.npmjs.org\mocha\6.2.2\node_modules\mocha\lib\cli\options.js
  • D:\a\1\s\common\temp\node_modules.pnpm\registry.npmjs.org\mocha\6.2.2\node_modules\mocha\bin\mocha
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:966:15)
    at Function.Module._load (internal/modules/cjs/loader.js:842:27)
    at Module.require (internal/modules/cjs/loader.js:1026:19)
    at require (internal/modules/cjs/helpers.js:72:18)
    at Object. (D:\a\1\s\packages\lu\test\commands\luis\translate.test.ts:4:14)
    at Module._compile (internal/modules/cjs/loader.js:1138:30)
    at Module.replacementCompile (D:\a\1\s\common\temp\node_modules.pnpm\registry.npmjs.org\append-transform\1.0.0\node_modules\append-transform\index.js:58:13)
    at Module.m._compile (D:\a\1\s\common\temp\node_modules.pnpm\registry.npmjs.org\ts-node\8.6.2_typescript@3.8.3\node_modules\ts-node\src\index.ts:814:23)
    at module.exports (D:\a\1\s\common\temp\node_modules.pnpm\registry.npmjs.org\default-require-extensions\2.0.0\node_modules\default-require-extensions\js.js:7:9)
    at D:\a\1\s\common\temp\node_modules.pnpm\registry.npmjs.org\append-transform\1.0.0\node_modules\append-transform\index.js:62:4
    at require.extensions. (D:\a\1\s\common\temp\node_modules.pnpm\registry.npmjs.org\ts-node\8.6.2_typescript@3.8.3\node_modules\ts-node\src\index.ts:817:12)
    at Object. (D:\a\1\s\common\temp\node_modules.pnpm\registry.npmjs.org\append-transform\1.0.0\node_modules\append-transform\index.js:62:4)
    at Module.load (internal/modules/cjs/loader.js:986:32)
    at Function.Module._load (internal/modules/cjs/loader.js:879:14)
    at Module.require (internal/modules/cjs/loader.js:1026:19)
    ...

@munozemilio munozemilio merged commit 86f0302 into master Jun 29, 2020
@munozemilio munozemilio deleted the v-bruhal/coveralls5-20 branch June 29, 2020 22:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Coveralls not showing the correct code coverge

3 participants