Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Comments

support endpoint via arg or cli config for luis and qnamaker build#845

Merged
feich-ms merged 2 commits intomasterfrom
feich/supportEndpointArg
Jun 11, 2020
Merged

support endpoint via arg or cli config for luis and qnamaker build#845
feich-ms merged 2 commits intomasterfrom
feich/supportEndpointArg

Conversation

@feich-ms
Copy link
Contributor

@feich-ms feich-ms commented Jun 8, 2020

fix #843

@feich-ms feich-ms requested a review from munozemilio as a code owner June 8, 2020 11:35
@feich-ms feich-ms requested review from boydc2014 and vishwacsena June 8, 2020 11:35
@vishwacsena
Copy link
Contributor

Does this mean they are also configurable via luconfig?
Also can we change --luconfig to --qnaconfig for qnamaker:build?

@feich-ms
Copy link
Contributor Author

@vishwacsena, yes, they are configurable via luConfig or qnaConfig. Just added the test cases to cover that. The typo of luConfig in qnamaker:build README is also resolved.

@feich-ms feich-ms merged commit 09d2523 into master Jun 11, 2020
@feich-ms feich-ms deleted the feich/supportEndpointArg branch June 11, 2020 13:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

luis:build should allow endpoint via arg or use from cli config

2 participants