Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Comments

add $schema for luis build and qnamaker build dialog files#844

Merged
feich-ms merged 4 commits intomasterfrom
feich/luisBuildFixes
Jun 11, 2020
Merged

add $schema for luis build and qnamaker build dialog files#844
feich-ms merged 4 commits intomasterfrom
feich/luisBuildFixes

Conversation

@feich-ms
Copy link
Contributor

@feich-ms feich-ms commented Jun 8, 2020

fix #817

@feich-ms feich-ms changed the title add schema parameters for luis build add schema parameters for luis build and qnamaker build Jun 8, 2020
@feich-ms feich-ms marked this pull request as ready for review June 8, 2020 11:09
@feich-ms feich-ms requested a review from munozemilio as a code owner June 8, 2020 11:09
@feich-ms feich-ms requested review from boydc2014 and vishwacsena June 8, 2020 11:09
@feich-ms feich-ms changed the title add schema parameters for luis build and qnamaker build add $schema for luis build and qnamaker build dialog files Jun 8, 2020
@vishwacsena vishwacsena requested a review from chrimc62 June 8, 2020 14:14
@vishwacsena
Copy link
Contributor

@chrimc62 can you please review?

@chrimc62
Copy link

chrimc62 commented Jun 8, 2020

Awesome to see this! Minor comments on typing tests and help.


In reply to: 640642751 [](ancestors = 640642751)

Copy link

@chrimc62 chrimc62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@feich-ms
Copy link
Contributor Author

feich-ms commented Jun 9, 2020

@chrimc62 comments resolved. Please let me know if they are not reasonable fixed. Thanks~

@feich-ms feich-ms requested a review from chrimc62 June 11, 2020 13:20
Copy link

@chrimc62 chrimc62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@feich-ms feich-ms merged commit 6536d7c into master Jun 11, 2020
@feich-ms feich-ms deleted the feich/luisBuildFixes branch June 11, 2020 23:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

luis:build does not include $schema in generated .dialog files

3 participants