This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Throw exception when parsing entity name contains invalid char#837
Merged
Throw exception when parsing entity name contains invalid char#837
Conversation
feich-ms
changed the title
vishwacsena
approved these changes
Jun 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #794. Before the fix, entity name with invalid char [<, >, *, %, &, :, , $] will throw exception when calling luis api, in such situation, line number or file name will not be shown to users as the lu content is merged from multiple files. After the fix, lu parser will throw such exception when parsing instead of publishing and it will contains file name and line number.