This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Conversation
vishwacsena
approved these changes
May 15, 2020
Contributor
vishwacsena
left a comment
vishwacsena
left a comment
There was a problem hiding this comment.
Verified this works functionally with qnamaker:build.
Contributor
Author
|
@munozemilio could you take a look if changes to qnamaker:kb:replace make sense to you? The reason to do this is that replace api targetting multi turn qna doesn't work well, so we convert the qna content to json format. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #766 and #769.
To fix #766, convert qna content to kb json and then call replace api. It works fine with multi turn.
To fix #769, The auto generated ids are actually working correctly when converted to json format.