Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Comments

CLI consistency of dialog:verify with dialog:merge, luis:build with config#741

Merged
chrimc62 merged 32 commits intomasterfrom
chrimc/verify2
May 3, 2020
Merged

CLI consistency of dialog:verify with dialog:merge, luis:build with config#741
chrimc62 merged 32 commits intomasterfrom
chrimc/verify2

Conversation

@chrimc62
Copy link

@chrimc62 chrimc62 commented May 2, 2020

Minimal updates to enable dialog:verify to work on dialog:merge schema files.
Changed luconfig.json to match luis:build arguments. This included:

  • Name -> botName
  • Added --deleteOldVersion to CLI
  • defaultLanguage -> defaultCuture
  • writeDialogFiles -> dialog

Added bf config:set:luis --authoringKey

* [`bf luis:version:import`](#bf-luisversionimport)
* [`bf luis:version:list`](#bf-luisversionlist)
* [`bf luis:version:rename`](#bf-luisversionrename)
- [@microsoft/bf-luis-cli](#microsoftbf-luis-cli)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets move line 22 and 23 outside the since this is replaced everytime npm run doc is executed


## luconfig.json
Some times you might need to have more control over which specific .lu files correspond to a luis application within your project folder. This is especially helpful if you are leveraging [external references][3] in your .lu files so not every single .lu file is treated as a LUIS application. To achieve this, you can author a luconfig.json and provide it via `bf luis:build --luconfig <luconfig.json path>`
Some times you might need to have more control over which specific .lu files correspond to a luis application within your project folder. This is especially helpful if you are leveraging [external references][3] in your .lu files so not every single .lu file is treated as a LUIS application. To achieve this, you can author a luconfig.json with command line switches in it and provide it via `bf luis:build --luconfig <luconfig.json path>`. You will need to also specify `--authoringKey <yourKey>` or set it via `bf config:set:luis --authoringKey=<yourKey>`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Casing is inconsistent on "luis" vs "LUIS".

@cleemullins
Copy link
Contributor

I've approved, and we should be good to merge once the build passes.

@chrimc62 chrimc62 merged commit b91b3a8 into master May 3, 2020
@chrimc62 chrimc62 deleted the chrimc/verify2 branch May 3, 2020 00:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants