Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Comments

Updates to BF-LU API#734

Merged
vishwacsena merged 2 commits intomasterfrom
vishwac/lu-api-update
Apr 27, 2020
Merged

Updates to BF-LU API#734
vishwacsena merged 2 commits intomasterfrom
vishwac/lu-api-update

Conversation

@vishwacsena
Copy link
Contributor

@vishwacsena vishwacsena commented Apr 27, 2020

  • Expose LuOptions. Without this users do not know what to pass in to fromLuAsync or to the delegate find file function.
  • Expose our custom implementation of read-text-file as a utility.

@tsuwandy ran into issues with these in the orchestrator CLI command that is taking a dependency on @microsoft/bf-lu library.

@vishwacsena vishwacsena added lu non luis api commands R9 Release 9 - May 15th, 2020 labels Apr 27, 2020
tsuwandy
tsuwandy approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@tsuwandy tsuwandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks vishwac!

@vishwacsena vishwacsena merged commit b28bd3d into master Apr 27, 2020
@vishwacsena vishwacsena deleted the vishwac/lu-api-update branch April 27, 2020 22:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@tsuwandy tsuwandy tsuwandy approved these changes

@munozemilio munozemilio munozemilio approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lu non luis api commands R9 Release 9 - May 15th, 2020

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vishwacsena @tsuwandy @munozemilio