This repository was archived by the owner on Jan 15, 2025. It is now read-only.
luis build support to extract authoringKey set by config:set#731
Merged
luis build support to extract authoringKey set by config:set#731
Conversation
feich-ms
changed the title
feich-ms
changed the title
vishwacsena
approved these changes
Apr 24, 2020
chrimc62
reviewed
Apr 27, 2020
| } | ||
|
|
||
| if (!flags.authoringKey && (!userConfig || !userConfig.authoringKey)) { | ||
| throw new CLIError('Missing luis authoring key. Please pass authoring key with --authoringKey flag') |
There was a problem hiding this comment.
luis [](start = 36, length = 4)
Should be LUIS.
chrimc62
reviewed
Apr 27, 2020
| if (!flags.authoringKey && (!userConfig || !userConfig.authoringKey)) { | ||
| throw new CLIError('Missing luis authoring key. Please pass authoring key with --authoringKey flag') | ||
| } else { | ||
| flags.authoringKey = flags.authoringKey || userConfig.authoringKey |
There was a problem hiding this comment.
userConfig.authoringKey [](start = 51, length = 23)
Is there a separate PR for adding this to config? Even if config allows anything, I would still expect to see documentation updates both for this command and for config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #666. After the fix, users can use bf config:set -k authoringKey -v xxxxxx to set the authoring key in config and luis build will extract the key from config if it is already set. After set users don't need to always provide authoring key in luis build command.