This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Updates to LU round tripping with luis_schema_version 7.0.0#730
Merged
vishwacsena merged 12 commits intomasterfrom Apr 24, 2020
Merged
Updates to LU round tripping with luis_schema_version 7.0.0#730vishwacsena merged 12 commits intomasterfrom
vishwacsena merged 12 commits intomasterfrom
Conversation
…into vishwac/686
vishwacsena
requested review from
clearab,
cleemullins,
feich-ms and
munozemilio
Contributor
|
@munozemilio, I don't think I'm qualified to signoff on this one. Can you take a look? |
munozemilio
reviewed
Apr 23, 2020
| if (item.featureName) featuresList.push(item.featureName); | ||
| if (item.modelName) featuresList.push(item.modelName); | ||
| if (item.modelName) { | ||
| if (item.isRequired !== undefined) { |
Contributor
There was a problem hiding this comment.
Is this the same?
if (item.isRequired === undefined ||
(item.isRequired !== undefined &&
item.isRequired !== true)) {
featuresList.push(item.modelName);
}
munozemilio
reviewed
Apr 23, 2020
| } | ||
|
|
||
| const isRootEntity = function (entityName, entitiesCollection) { | ||
| if ((entitiesCollection || []).find(ecEntity => ecEntity.name == entityName) !== undefined) |
Contributor
There was a problem hiding this comment.
return ((entitiesCollection || []).find(ecEntity => ecEntity.name == entityName) !== undefined) directly?
munozemilio
approved these changes
Apr 23, 2020
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ prebuiltType entityNamenotation. Under the cover this will be transformed (unless not within an nDepth entity) to prebuilt type with a role for entityName.