Conversation
luhan2017
commented
Apr 23, 2020
- Upate the component schema location
- And fix the mandatory -b ""
|
I wish I had known this is blocking you--I've been working on fixing this and many other issues over the last couple of days. I'll try to finish it today so this should just be a stop-gap. |
|
@chrimc62 , If you are working on this, please just go ahead to check in and close my PR. I am blocking by this to update sdk.schema for composer, I don't want to bother you for such small case :) I removed -b and -u from the script directly since I think it won't be used any more. Please let me know if there is still issue. |
All feedback has been resolved by Lu Han.
|
@chrimc - all of your feedback has been addressed by @luhan2017. I've dismissed your review so that she can go ahead and merge once the build is completed. |
|
Sure, but I’m going to be overriding all of that soon. I thought I had approved that?
|
|
@chrimc62 The review hadn't been signed off. You had given feedback, and she resolved, but you never gave approval so she couldn't merge. With all of your feedbacked completed, I felt comfortable signing off, and working with her to merge. |