Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Comments

update component location#729

Merged
cleemullins merged 8 commits intomasterfrom
luhan/updateComponentLocation
Apr 28, 2020
Merged

update component location#729
cleemullins merged 8 commits intomasterfrom
luhan/updateComponentLocation

Conversation

@luhan2017
Copy link
Contributor

  1. Upate the component schema location
  2. And fix the mandatory -b ""

@luhan2017 luhan2017 requested a review from tomlm April 23, 2020 03:48
@vishwacsena vishwacsena requested a review from chrimc62 April 23, 2020 06:09
@vishwacsena vishwacsena added the R9 Release 9 - May 15th, 2020 label Apr 23, 2020
@chrimc62
Copy link

I wish I had known this is blocking you--I've been working on fixing this and many other issues over the last couple of days. I'll try to finish it today so this should just be a stop-gap.

Copy link

@chrimc62 chrimc62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@luhan2017
Copy link
Contributor Author

@chrimc62 , If you are working on this, please just go ahead to check in and close my PR. I am blocking by this to update sdk.schema for composer, I don't want to bother you for such small case :) I removed -b and -u from the script directly since I think it won't be used any more. Please let me know if there is still issue.

@cleemullins cleemullins dismissed chrimc62’s stale review April 28, 2020 02:05

All feedback has been resolved by Lu Han.

@cleemullins
Copy link
Contributor

@chrimc - all of your feedback has been addressed by @luhan2017. I've dismissed your review so that she can go ahead and merge once the build is completed.

@chrimc
Copy link

chrimc commented Apr 28, 2020 via email

@cleemullins
Copy link
Contributor

@chrimc62 The review hadn't been signed off. You had given feedback, and she resolved, but you never gave approval so she couldn't merge. With all of your feedbacked completed, I felt comfortable signing off, and working with her to merge.

@cleemullins cleemullins merged commit 9ed91f7 into master Apr 28, 2020
@cleemullins cleemullins deleted the luhan/updateComponentLocation branch April 28, 2020 02:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

R9 Release 9 - May 15th, 2020

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants