This repository was archived by the owner on Jan 15, 2025. It is now read-only.
fix source .vs. ID order in JSON -> QnA format#710
Merged
vishwacsena merged 6 commits intomasterfrom Apr 24, 2020
Merged
Conversation
munozemilio
approved these changes
Apr 14, 2020
tsuwandy
approved these changes
Apr 14, 2020
Contributor
Author
|
@vipeketi can you please take a look at this change as well? This bears an impact on the import format to QnA maker in that the ID will now appear after the source. Need update to the download as well as need to ensure replace API supports it as well. |
tsuwandy
approved these changes
Apr 14, 2020
Contributor
Author
|
@vipeketi can you comment if you can take this change on the QnA service side as well? |
@vishwacsena I have made changes for our implementation as below. Hope it works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tien discovered this issue.Simple fix to get both the JSON -> QnA as well as QnA -> JSON be consistent in the order information should appear in .qna format.