This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Merged
Conversation
feich-ms
requested review from
0rland0Wats0n,
boydc2014,
luhan2017,
munozemilio and
vishwacsena
and removed request for
0rland0Wats0n
luhan2017
reviewed
Apr 14, 2020
Contributor
luhan2017
left a comment
luhan2017
left a comment
There was a problem hiding this comment.
https://github.com/microsoft/botbuilder-dotnet/blob/9921ba63da3aeebb108d1d70ae5a64942c533102/schemas/sdk.schema#L5504 there are more configurations than those two, could you please also add the others.
Contributor
Author
|
added all the properties @luhan2017 |
luhan2017
reviewed
Apr 14, 2020
Contributor
Author
|
Can anyone approve this PR if it looks good to you? @vishwacsena @luhan2017 |
vishwacsena
approved these changes
Apr 23, 2020
munozemilio
approved these changes
Apr 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix issue here microsoft/BotFramework-Composer#2545