[qnamaker] Export as well as replace support for .qna format#695
[qnamaker] Export as well as replace support for .qna format#695munozemilio merged 2 commits intomasterfrom
Conversation
|
@feich-ms can you look at this PR in the context of qnamaker:build and comment if we can switch to use .qnaformat for both replace as well as export needs? I have not played with qnamaker:build yet but will do so after this is reviewed and merged in and you have been able to get multi-turn supported in qnamaker:build. Also I hope we do not do create w/ KB in qnamaker:build. It always has to be a create command followed by replace for qnamaker:build since the create command does not support .qna format. |
|
Will have a try |
|
@vishwacsena, I am OOF this Wednesday and Thursday, so I haven't got a chance to try it. But from tests, it seems to work well. One question is if I export with qna format, will it reconstruct the url and file references to qna files? If not, we can not compare the qna format contents to decide whether updating knowledge base just like we do in luis build. I will give updates soon when I'm back to work. |
|
@feich-ms export will not reconstruct url and file references. The way to do it would be to complete cross-train etc on our side, put together the single qna KB (per locale) and compare it against the exported qna document. We might need to do some work on the comparison end to sort on questions and answers like we did for luis but other than that, that's how we should compare. |
|
@vishwacsena, I just tried to create an empty kb and then replace it with the multiturn qna content. It works now. But if I added a file or url referernce in the qna content, the referenced qna pairs are not included in published kb. So is it reasonable or valid if file or url references exist in multiturn qna file. What to do if file or url references are in multiturn qna content? My proposal is
How do you think? |
|
@vishwacsena, I double tried and confirmed that URI or file reference are not supported under qna format. If they are not planned to support, I think we can always do step 3 to keep consistency for all lu files. If they are already suppoerted, we can drop the update api call for reference in step 3. Please help to confirm. Thanks. |
|
@feich-ms I find your approach of combining replace and update api as best approach for taking care of URI or file refernce updates. |
Fixes #670 and #673