This repository was archived by the owner on Jan 15, 2025. It is now read-only.
optimize section body extraction and error handling#679
Merged
Conversation
feich-ms
requested review from
boydc2014,
munozemilio,
vishwacsena and
zhixzhan
Contributor
|
@zhixzhan you should take a look and try this out, see if it resolves the issue we face in Composer |
|
@boydc2014 Tried, mostly looks good, rest some detail issue I offline talked to Fei. |
Contributor
Author
|
Updated to the latest version. please try again @zhixzhan |
zhixzhan
approved these changes
Mar 23, 2020
boydc2014
approved these changes
Mar 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix requirements from composer microsoft/BotFramework-Composer#2267