Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Teams connector client creation cleanup #536

Merged
tracyboehrer merged 2 commits into from
Dec 18, 2019
Merged

Teams connector client creation cleanup #536

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82ab72d
access _credentials from turncontext adapter when creating teams conn…
Dec 17, 2019
c1d5850
Merge branch 'master' into eric/fixGetTeamsConnectorClient
Dec 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions libraries/botbuilder-core/botbuilder/core/teams/teams_info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,11 @@ async def get_members(turn_context: TurnContext) -> List[TeamsChannelAccount]:
async def get_teams_connector_client(
turn_context: TurnContext,
) -> TeamsConnectorClient:
connector_client = await TeamsInfo._get_connector_client(turn_context)
return TeamsConnectorClient(
connector_client.config.credentials, turn_context.activity.service_url
turn_context.adapter._credentials, # pylint: disable=protected-access
turn_context.activity.service_url,
)

# TODO: should have access to adapter's credentials
# return TeamsConnectorClient(turn_context.adapter._credentials, turn_context.activity.service_url)

@staticmethod
def get_team_id(turn_context: TurnContext):
channel_data = TeamsChannelData(**turn_context.activity.channel_data)
Expand Down