Skip to content

Cherry Pick to 4.7: Update comments in teams_helper (#531) #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Cherry Pick to 4.7: Update comments in teams_helper (#531) #533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion libraries/botbuilder-core/botbuilder/core/teams/teams_activity_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,6 @@ async def on_teams_members_removed_dispatch( # pylint: disable=unused-argument
):
teams_members_removed = []
for member in members_removed:
# TODO: fix this
new_account_json = member.serialize()
if "additional_properties" in new_account_json:
del new_account_json["additional_properties"]
Expand Down
6 changes: 3 additions & 3 deletions libraries/botbuilder-core/botbuilder/core/teams/teams_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@
import botbuilder.schema as schema
import botbuilder.schema.teams as teams_schema

# Optimization: The dependencies dictionary could be cached here,
# and shared between the two methods.


def deserializer_helper(msrest_cls: Type[Model], dict_to_deserialize: dict) -> Model:
dependencies = [
Expand All @@ -27,9 +30,6 @@ def deserializer_helper(msrest_cls: Type[Model], dict_to_deserialize: dict) -> M
return deserializer(msrest_cls.__name__, dict_to_deserialize)


# TODO consolidate these two methods


def serializer_helper(object_to_serialize: Model) -> dict:
if object_to_serialize is None:
return None
Expand Down