Skip to content

Josh/private helpers #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 17, 2019
Merged

Josh/private helpers #530

merged 5 commits into from
Dec 17, 2019

Conversation

Virtual-Josh
Copy link
Contributor

No description provided.

@Virtual-Josh Virtual-Josh added teams R7 Release 7 - December 10th, 2019 labels Dec 17, 2019
Copy link
Member

@johnataylor johnataylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! @tracyboehrer can you confirm?

@tracyboehrer
Copy link
Member

tracyboehrer commented Dec 17, 2019

@Virtual-Josh @johnataylor This is set to merge to 4.7 directly. Do we not also want these changes in master?

@Virtual-Josh
Copy link
Contributor Author

@Virtual-Josh @johnataylor This is set to merge to 4.7 directly. Do we not also want these changes in master?

I was going to cherry pick them over after it was merged here.

@BruceHaley BruceHaley merged commit e568afe into 4.7 Dec 17, 2019
@Virtual-Josh
Copy link
Contributor Author

Same PR in master:
#535

@Virtual-Josh Virtual-Josh deleted the josh/privateHelpers branch March 31, 2020 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R7 Release 7 - December 10th, 2019
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants