Skip to content

updating create conversation to take conversation params #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 12, 2019

Conversation

Virtual-Josh
Copy link
Contributor

No description provided.

@johnataylor
Copy link
Member

johnataylor commented Dec 11, 2019

Looks like the create_conversation code in Python is not setting the activity type nor the activity name on the event activity that is used to run the middleware.

Specifically the code:

request = TurnContext.apply_conversation_reference(
                Activity(), reference, is_incoming=True
            )

should set the Activity to have type = "event" and name = "CreateConversation"

@Virtual-Josh Virtual-Josh added R7 Release 7 - December 10th, 2019 teams labels Dec 12, 2019
@johnataylor johnataylor merged commit 4a2ecef into master Dec 12, 2019
@johnataylor johnataylor deleted the josh/adapter branch December 12, 2019 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R7 Release 7 - December 10th, 2019
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants