Skip to content

Corrected type hint on AttachmentPrompt __init__ #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 13, 2019
Merged

Corrected type hint on AttachmentPrompt __init__ #489

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3d53599
Corrected type hint on AttachmentPrompt __init__
tracyboehrer Dec 10, 2019
c1a057d
Merge branch 'master' into trboehre/attachmentprompt-fix
tracyboehrer Dec 11, 2019
cce7afe
Corrected black complaints
tracyboehrer Dec 11, 2019
a3638a5
Merge branch 'trboehre/attachmentprompt-fix' of https://github.com/mi…
tracyboehrer Dec 11, 2019
82f76ab
Merge branch 'master' into trboehre/attachmentprompt-fix
tracyboehrer Dec 11, 2019
d2599f9
Merge branch 'master' into trboehre/attachmentprompt-fix
axelsrz Dec 13, 2019
5490485
Merge branch 'master' into trboehre/attachmentprompt-fix
axelsrz Dec 13, 2019
867ca04
Merge branch 'master' into trboehre/attachmentprompt-fix
tracyboehrer Dec 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions libraries/botbuilder-dialogs/botbuilder/dialogs/prompts/attachment_prompt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@

from typing import Callable, Dict

from botbuilder.schema import ActivityTypes, Attachment, InputHints
from botbuilder.schema import ActivityTypes, InputHints
from botbuilder.core import TurnContext

from .prompt import Prompt
from .prompt import Prompt, PromptValidatorContext
from .prompt_options import PromptOptions
from .prompt_recognizer_result import PromptRecognizerResult

Expand All @@ -18,7 +18,9 @@ class AttachmentPrompt(Prompt):
By default the prompt will return to the calling dialog an `[Attachment]`
"""

def __init__(self, dialog_id: str, validator: Callable[[Attachment], bool] = None):
def __init__(
self, dialog_id: str, validator: Callable[[PromptValidatorContext], bool] = None
):
super().__init__(dialog_id, validator)

async def on_prompt(
Expand Down