Skip to content

Auth changes for skills #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 25, 2019
Merged

Auth changes for skills #420

merged 10 commits into from
Nov 25, 2019

Conversation

axelsrz
Copy link
Member

@axelsrz axelsrz commented Nov 7, 2019 •
edited
Loading

Solves #342
Solves #319

@axelsrz axelsrz requested a review from gabog November 7, 2019 23:00
@axelsrz axelsrz changed the title auth changes for skills, tests pending Auth changes for skills Nov 9, 2019
@axelsrz axelsrz marked this pull request as ready for review November 9, 2019 00:37
@axelsrz axelsrz requested review from johnataylor and daveta November 9, 2019 00:37
@carlosscastro
Copy link
Member

Changes look good overall. What is the plan to get these in? Include all skill work and merge in one PR or merge this in and then the rest of skills?

Ideally I'd love to merge this in once we have 1) functional tests for skills and 2) functional auth tests to make sure that the regular path authentication has not been affected.

@tracyboehrer
Copy link
Member

Changes look good overall. What is the plan to get these in? Include all skill work and merge in one PR or merge this in and then the rest of skills?

Ideally I'd love to merge this in once we have 1) functional tests for skills and 2) functional auth tests to make sure that the regular path authentication has not been affected.

In the Teams case, Josh is pushing to another branch. The plan is to then merge that into master when done. Would we not want to do the same here so we don't end up with something incomplete if we we don't finish?

stevengum
stevengum reviewed Nov 25, 2019
View reviewed changes
libraries/botframework-connector/botframework/connector/auth/jwt_token_extractor.py
@@ -64,27 +73,46 @@ def _has_allowed_issuer(self, jwt_token: str) -> bool:
if issuer in self.validation_parameters.issuer:
return True

return issuer is self.validation_parameters.issuer
return issuer == self.validation_parameters.issuer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix!

@axelsrz axelsrz merged commit 6f81404 into master Nov 25, 2019
@axelsrz axelsrz deleted the axsuarez/auth-for-skills branch November 25, 2019 23:38
@axelsrz axelsrz mentioned this pull request Nov 25, 2019
Closed
This was referenced Dec 6, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@carlosscastro carlosscastro carlosscastro approved these changes

@gabog gabog Awaiting requested review from gabog

@johnataylor johnataylor Awaiting requested review from johnataylor

@daveta daveta Awaiting requested review from daveta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@axelsrz @carlosscastro @tracyboehrer @stevengum