Skip to content

[Deployment] Modify echo-bot to work out of the box w/ new ARM template #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 5, 2019

Conversation

stevengum
Copy link
Member

Specific Changes

  • Rename flask APP to app to utilize Azure's automated flask app:app detection
  • Add ARM template with Linux App Service and Linux App Service Plan provisioning
    • Note: The ARM template automatically configures kudu to build on deployment, which differs from the Node.js model where the developer is expected to include their local node_modules/

The commands used to deploy with this ARM template mirror the steps found in the docs page: "Deploy your bot"

Commands:

az ad app create --display-name "MSAAppName" --password "AppPassword" --available-to-other-tenants

# When using from the root of the 02.echo-bot sample
az group deployment create --name "deployment-name" --resource-group "resource-group" --template-file "deploymentTemplates/template-with-preexisting-rg.json" --parameters appId="AppIdOutputFromPreviousCommand" appSecret="AppPassword" botId="UniqueIdOrNameForBot" newWebAppName="NameOfLinuxAppService" newAppServicePlanName="NameOfLinuxAppServicePlan" appServicePlanLocation="LocationToBeUsedForCreatingResources"

az webapp deployment source config-zip --resource-group "resource-group" --name "NameOfLinuxAppService" --src "02.echo-bot.zip"

Follow-up

  • Flask samples need to be updated so that the flask APP is app
  • Investigate performing a zip-deploy with a virtual environment already configured.
    • Oryx's venv name looks to be antenv

@stevengum stevengum added the R7 Release 7 - December 10th, 2019 label Nov 5, 2019
Copy link
Member

@tracyboehrer tracyboehrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with echo-bot. Works perfect.

Add future tasks: template for new RG.

Add to steps: Manually zip before final 'az' command.

@tracyboehrer tracyboehrer merged commit 8646e74 into master Nov 5, 2019
@tracyboehrer tracyboehrer deleted the stgum/deployEcho branch November 5, 2019 14:14
@stevengum stevengum mentioned this pull request Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R7 Release 7 - December 10th, 2019
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants