Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

don't await synchronous method #322

Merged
axelsrz merged 4 commits into from
Oct 17, 2019
Merged

don't await synchronous method #322

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b770dd9
don't await synchronous method
dominiquehunziker Sep 22, 2019
c33a207
Merge branch 'master' into sync-fix
axelsrz Oct 1, 2019
765432f
Merge branch 'master' into sync-fix
axelsrz Oct 17, 2019
587de9a
Merge branch 'master' into sync-fix
axelsrz Oct 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions libraries/botbuilder-core/botbuilder/core/transcript_logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ async def send_activities_handler(
# Run full pipeline
responses = await next_send()
for activity in activities:
await self.log_activity(transcript, copy.copy(activity))
self.log_activity(transcript, copy.copy(activity))
return responses

context.on_send_activities(send_activities_handler)
Expand All @@ -71,7 +71,7 @@ async def update_activity_handler(
response = await next_update()
update_activity = copy.copy(activity)
update_activity.type = ActivityTypes.message_update
await self.log_activity(transcript, update_activity)
self.log_activity(transcript, update_activity)
return response

context.on_update_activity(update_activity_handler)
Expand All @@ -91,7 +91,7 @@ async def delete_activity_handler(
deleted_activity: Activity = TurnContext.apply_conversation_reference(
delete_msg, reference, False
)
await self.log_activity(transcript, deleted_activity)
self.log_activity(transcript, deleted_activity)

context.on_delete_activity(delete_activity_handler)

Expand Down