Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Conversation

@gurvsing
Copy link
Contributor

@gurvsing gurvsing commented Sep 3, 2019

Description

Addition of a new optional parameter (qnaId) in GenerateAnswer body.

Specific Changes

  • Support for QnA Id added

Testing

Test case added

@gurvsing gurvsing requested review from axelsrz and cleemullins and removed request for axelsrz September 3, 2019 13:07
Copy link
Contributor

@cleemullins cleemullins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same feedback.

Please include an issue # that's being fixed.
Improve the description of the PR, as these are used to auto-generate Release Notes.
Code changed, so there need to be test changes.

@gurvsing gurvsing changed the title QnAMaker Multi-turn fix [QnA Maker] multi-turn SDK support for QnAID Sep 3, 2019
@gurvsing gurvsing requested a review from cleemullins September 3, 2019 19:21
@gurvsing gurvsing changed the title [QnA Maker] multi-turn SDK support for QnAID [QnA Maker] Multi-turn SDK support for QnAId Sep 3, 2019
@axelsrz axelsrz dismissed cleemullins’s stale review September 4, 2019 16:35

Changes addressed

@axelsrz axelsrz merged commit 9d41ec4 into master Sep 4, 2019
@axelsrz axelsrz deleted the gurvsing/fix branch September 4, 2019 16:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants