This repository was archived by the owner on Jan 5, 2026. It is now read-only.
Support oauth and oauth prompt #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Removed duplicated token_api code from connector.
… into axsuarez/support-oauth-and-gov Merge with master
libraries/botbuilder-core/botbuilder/core/adapters/test_adapter.py
Outdated
Show resolved
Hide resolved
libraries/botbuilder-core/botbuilder/core/adapters/test_adapter.py
Outdated
Show resolved
Hide resolved
stevengum
previously requested changes
Jun 28, 2019
libraries/botframework-connector/botframework/connector/emulator_api_client.py
Show resolved
Hide resolved
libraries/botframework-connector/botframework/connector/auth/microsoft_app_credentials.py
Show resolved
Hide resolved
johnataylor
approved these changes
Jul 3, 2019
| key.user_id = context.activity.from_property.id | ||
|
|
||
| if magic_code: | ||
| magic_code_record = list(filter(lambda x: key.equals_key(x.key), self._magic_codes)) |
Member
There was a problem hiding this comment.
consider a list comprehension?
| inspector(reply, description) | ||
|
|
||
| else: | ||
| await asyncio.sleep(0.05) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
fixes #183
partially #186 , #174