This repository was archived by the owner on Jan 5, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsuwandy
approved these changes
May 31, 2019
samples/python-flask/21.corebot-app-insights/bots/dialog_and_welcome_bot.py
Outdated
Show resolved
Hide resolved
stevengum
suggested changes
Jun 5, 2019
Member
stevengum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs some small cleanup
samples/python-flask/21.corebot-app-insights/dialogs/cancel_and_help_dialog.py
Show resolved
Hide resolved
samples/python-flask/21.corebot-app-insights/dialogs/main_dialog.py
Outdated
Show resolved
Hide resolved
stevengum
approved these changes
Jun 24, 2019
Member
stevengum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some nitpicks but once those are fixed it should be good to go.
| @@ -1,5 +1,6 @@ | |||
| # Copyright (c) Microsoft Corporation. All rights reserved. | |||
| # Licensed under the MIT License. | |||
| """Djanjo Application Insights package.""" | |||
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo here, should be "Django"
...ilder-applicationinsights/botbuilder/applicationinsights/flask/flask_telemetry_middleware.py
Outdated
Show resolved
Hide resolved
samples/python-flask/21.corebot-app-insights/dialogs/main_dialog.py
Outdated
Show resolved
Hide resolved
...uilder-applicationinsights/botbuilder/applicationinsights/django/bot_telemetry_middleware.py
Outdated
Show resolved
Hide resolved
… into daveta-appinsights-sample
…oft/botbuilder-python into daveta-appinsights-sample
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a Flask + Application Insights sample based on Core-Bot
In particular: