Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Fix get_skill_conversation_reference in skill_handler #1728

Merged
tracyboehrer merged 2 commits into from
Jun 22, 2021
Merged

Fix get_skill_conversation_reference in skill_handler #1728

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a99651c
Add check for instance of SkillConversationReference
santgr11 Jun 17, 2021
1fc7929
Apply black styling
santgr11 Jun 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions libraries/botbuilder-core/botbuilder/core/skills/skill_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,14 +200,18 @@ async def _get_skill_conversation_reference(
conversation_id
)

skill_conversation_reference: SkillConversationReference = SkillConversationReference(
conversation_reference=conversation_reference,
oauth_scope=(
GovernmentConstants.TO_CHANNEL_FROM_BOT_OAUTH_SCOPE
if self._channel_provider and self._channel_provider.is_government()
else AuthenticationConstants.TO_CHANNEL_FROM_BOT_OAUTH_SCOPE
),
)
if isinstance(conversation_reference, SkillConversationReference):
skill_conversation_reference: SkillConversationReference = conversation_reference
else:
skill_conversation_reference: SkillConversationReference = SkillConversationReference(
conversation_reference=conversation_reference,
oauth_scope=(
GovernmentConstants.TO_CHANNEL_FROM_BOT_OAUTH_SCOPE
if self._channel_provider
and self._channel_provider.is_government()
else AuthenticationConstants.TO_CHANNEL_FROM_BOT_OAUTH_SCOPE
),
)

if not skill_conversation_reference:
raise KeyError("SkillConversationReference not found")
Expand Down