Skip to content

Corrected bug with serialize attempt on a dict #1726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 26, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libraries/botbuilder-ai/tests/requirements.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
aioresponses~=0.6.3
aioresponses~=0.7.2
Original file line number Diff line number Diff line change
Expand Up @@ -511,10 +511,7 @@ async def process_activity_with_identity(
if invoke_response is None:
return InvokeResponse(status=int(HTTPStatus.NOT_IMPLEMENTED))
return InvokeResponse(
status=invoke_response.value.status,
body=invoke_response.value.body.serialize()
if invoke_response.value.body
else None,
status=invoke_response.value.status, body=invoke_response.value.body,
)

return None
Expand Down
8 changes: 4 additions & 4 deletions libraries/botbuilder-core/tests/test_bot_framework_adapter.py
Original file line number Diff line number Diff line change
Expand Up @@ -815,9 +815,9 @@ async def callback(context: TurnContext):

assert invoke_response
assert invoke_response.status == 200
assert invoke_response.body["id"] == inbound_activity.value.id
assert invoke_response.body.id == inbound_activity.value.id
assert (
invoke_response.body["connectionName"]
invoke_response.body.connection_name
== inbound_activity.value.connection_name
)

Expand Down Expand Up @@ -880,8 +880,8 @@ async def callback(context):

assert invoke_response
assert invoke_response.status == 200
assert invoke_response.body["id"] == inbound_activity.value.id
assert invoke_response.body.id == inbound_activity.value.id
assert (
invoke_response.body["connectionName"]
invoke_response.body.connection_name
== inbound_activity.value.connection_name
)
2 changes: 1 addition & 1 deletion libraries/botbuilder-integration-aiohttp/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"botframework-connector==4.14.0",
"botbuilder-core==4.14.0",
"yarl<=1.4.2",
"aiohttp~=3.6.2",
"aiohttp>=3.6.2,<3.8.0",
]

root = os.path.abspath(os.path.dirname(__file__))
Expand Down
2 changes: 1 addition & 1 deletion libraries/botbuilder-testing/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
botbuilder-schema==4.14.0
botbuilder-core==4.14.0
botbuilder-dialogs==4.14.0
aiounittest==1.3.0
aiounittest==1.4.0
4 changes: 2 additions & 2 deletions libraries/botframework-connector/tests/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
pytest-cov>=2.6.0
pytest==5.2.2
pytest~=6.2.3
azure-devtools>=0.4.1
pytest-asyncio==0.10.0
pytest-asyncio==0.15.1
ddt==1.2.1