Adaptive Card Tabs #1486
Adaptive Card Tabs #1486
Conversation
|
|
||
| :returns: A Tab Response for the request. | ||
| """ | ||
| return |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Thanks a lot for piointing this! I moved the methods to their corresponding place on added this fix
| """ | ||
|
|
||
| _attribute_map = { | ||
| "tab_entity_context": {"key": "tabEntityContext", "type": "TabEntityContext"}, |
There was a problem hiding this comment.
Will this look for the JSON property, tabContext? See .NET
libraries/botbuilder-schema/botbuilder/schema/teams/_models_py3.py
Outdated
Show resolved
Hide resolved
| """ | ||
|
|
||
| _attribute_map = { | ||
| "tab_entity_context": {"key": "tabEntityContext", "type": "TabEntityContext"}, |
There was a problem hiding this comment.
I believe we need the same tabContext change here.
|
|
||
| _attribute_map = { | ||
| "type": {"key": "type", "type": "str"}, | ||
| "properties": {"key": "properties", "type": "object"}, |
There was a problem hiding this comment.
I don't believe this will parse correctly (but I don't know Python well, so SUPER open to being wrong, here). The spec is:
{
"name": "tab/submit",
"value": {
"data": {
"type": "tab/submit",
// ... <data properties>
},
[...]
}My understanding is that there won't be a properties key, so much as an unknown amount keys with unknown names. @EricDahlvang @clearab Is this a correct interpretation of the spec?
If so, here's how I handled it in JS (not sure what the Py equivalent is).
There was a problem hiding this comment.
This should be handled similarly to the Properties field on Entity, ConversationAccount, ChannelAccount, Activity, etc.
|
@axelsrz i think this looks good, but need a sample to test against... can you port this one: microsoft/BotBuilder-Samples#3072 |
Fixes #1463