Skip to content

DialogManager #1409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Feb 1, 2021
Merged

DialogManager #1409

merged 22 commits into from
Feb 1, 2021

Conversation

axelsrz
Copy link
Member

@axelsrz axelsrz commented Oct 15, 2020 •
edited by tracyboehrer
Loading

Fixes #1237

DialogManager support

This PR is ready for review but awaiting for more unit tests

@axelsrz axelsrz changed the title Initial commit for dialog manager **WIP state** DialogManager **WIP state** Oct 15, 2020
@axelsrz axelsrz marked this pull request as draft November 13, 2020 22:46
@axelsrz axelsrz changed the title DialogManager **WIP state** DialogManager Nov 24, 2020
@axelsrz axelsrz marked this pull request as ready for review November 24, 2020 00:32
EricDahlvang
EricDahlvang reviewed Jan 22, 2021
View reviewed changes
Copy link
Member

@EricDahlvang EricDahlvang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not get through the entire PR. I think this is a little outdated from the current c# DialogManager. Please let me know when you're ready, and i'll make another pass.

@axelsrz axelsrz requested a review from EricDahlvang January 24, 2021 03:07
@tracyboehrer tracyboehrer merged commit 34e6109 into main Feb 1, 2021
@tracyboehrer tracyboehrer deleted the axsuarez/DialogManager branch February 1, 2021 14:08
@tracyboehrer tracyboehrer mentioned this pull request Feb 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tracyboehrer tracyboehrer tracyboehrer approved these changes

@EricDahlvang EricDahlvang Awaiting requested review from EricDahlvang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port DialogManager
3 participants
@axelsrz @tracyboehrer @EricDahlvang