Skip to content

[PORT] Implement hash for App Insights session ID #673

@tomlm

Description

@tomlm

Port this change from botbuilder-dotnet/master branch:
microsoft/botbuilder-dotnet#3317

Addresses this issue reported in JS microsoft/botbuilder-js#1512

App Insights has a maximum session ID of 64 characters, but in some instances for some channels (such as reported with Teams) this may be exceeded due to conversation ID currently being used for session ID. This PR hashes the conversation ID and sets this as the session ID. It also adds an additional telemetry property to ensure we retain the original conversation ID within the telemetry.

The hashed ID is only used for Application Insights and the original conversation ID and activity are left untouched.

Changed projects

  • integration

Metadata

Metadata

Assignees

Labels

P1Painful if we don't fix, won't block releasingR10Release 10 - August 17th, 2020

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions