Closed
Description
Version
4.13.0
Describe the bug
When the skill bot doesn't have credentials set, the is_skill_claim validation returns false because it checks the version_claim
before checking the anonymous_skill_app_id
.
In .NET and JS SDKs, the order of the validation is the opposite.
This is causing that the EndOfConversation activities are not sent when returning DialogTurnResult(DialogTurnStatus.Complete)
from a dialog.
This issue affects local testing when no credentials are provided for the bot.
To Reproduce
Steps to reproduce the behavior:
- Using the following bots: WaterfallHostBotDotNet and WaterfallSkillBotPython:
- Run the bots.
- Open BotFramework Emulator and connect to your host bot.
- Follow the dialog selecting:
normal
delivery mode,Waterfall
skills,3. WaterfallSkillBotPython
,1. Cards
skill action andend
option. - See how the bots stop responding.
Expected behavior
When selecting end
(return DialogTurnResult(DialogTurnStatus.Complete))
the skill bot must end the dialog sending an EOC activity to the host bot so this one can continue the dialog flow.