Skip to content

is_skill_claim validation is not working for Anonymous authentication #1683

Closed
@ceciliaavila

Description

@ceciliaavila

Version

4.13.0

Describe the bug

When the skill bot doesn't have credentials set, the is_skill_claim validation returns false because it checks the version_claim before checking the anonymous_skill_app_id.
In .NET and JS SDKs, the order of the validation is the opposite.

image

This is causing that the EndOfConversation activities are not sent when returning DialogTurnResult(DialogTurnStatus.Complete) from a dialog.
This issue affects local testing when no credentials are provided for the bot.

To Reproduce

Steps to reproduce the behavior:

  1. Using the following bots: WaterfallHostBotDotNet and WaterfallSkillBotPython:
  2. Run the bots.
  3. Open BotFramework Emulator and connect to your host bot.
  4. Follow the dialog selecting: normal delivery mode, Waterfall skills, 3. WaterfallSkillBotPython, 1. Cards skill action and end option.
  5. See how the bots stop responding.

image

Expected behavior

When selecting end (return DialogTurnResult(DialogTurnStatus.Complete)) the skill bot must end the dialog sending an EOC activity to the host bot so this one can continue the dialog flow.

Metadata

Metadata

Assignees

Labels

Area: SkillsThe issue is related to skillsExemptFromDailyDRIReportUse this label to exclude the issue from the DRI report.bugIndicates an unexpected problem or an unintended behavior.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions