Skip to content

Incorrect adal requirement in botframework-connector setup.py #1620

Closed
@cas--

Description

@cas--

Version

botframework-connector 4.12.0

Describe the bug

While looking into dependencies installed by botframework-connector I saw that deprecated adal in addition to msal.

The requirements.txt does not have this requirement but setup.py does

I did a quick github search and no reference to adal and looks like it was replaced with msal here: 5a62280

To Reproduce

pip install botframework-connector

Expected behavior

No unneeded pip packages

Metadata

Metadata

Labels

Bot ServicesRequired for internal Azure reporting. Do not delete. Do not change color.bugIndicates an unexpected problem or an unintended behavior.customer-replied-toIndicates that the team has replied to the issue reported by the customer. Do not delete.customer-reportedIssue is created by anyone that is not a collaborator in the repository.

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions