Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Conversation

@Bill7zz
Copy link
Contributor

@Bill7zz Bill7zz commented Apr 5, 2019

Description

This Pr will Fix the issue #840
Also, we updated the Read method to handle a partitioned CosmosDb collection.

Testing

Added the Test for Reading and Deleting operations on partitioned collections.

  • Read with partitionKey
  • Read without partitionKey
  • Delete with partitionKey
  • Delete without partitionKey

Note: To get the nock responses files, we ran the test in record mode after that, we set it back to lockdown mode.

image

@coveralls
Copy link

coveralls commented Apr 5, 2019

Pull Request Test Coverage Report for Build #2180

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 87.702%

Totals Coverage Status
Change from base Build #2179: 0.04%
Covered Lines: 3207
Relevant Lines: 3513

💛 - Coveralls

@cleemullins
Copy link
Contributor

@Bill7zz Could you "touch" the PR in some way to retrigger the build? We changed the build names and branch protection rules on Friday and it looks like this PR was caught in the middle.

@Bill7zz
Copy link
Contributor Author

Bill7zz commented Apr 9, 2019

@Bill7zz Could you "touch" the PR in some way to retrigger the build? We changed the build names and branch protection rules on Friday and it looks like this PR was caught in the middle.

Sure! I have just pushed some minor changes and the build has been re-triggerd.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants