Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#4684] Update INodeSocket type #4767

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sw-joelmut
Copy link
Collaborator

Addresses #4684
#minor

Description

This PR updates the INodeSocket type to support the latest Node types. Additionally, it adds a new INodeDuplex interface, to address an issue where either express or restify provided a Duplex socket.

Specific Changes

  • Remove INodeSocket properties, and inherit them from net.Socket directly.
  • Added INodeDuplex that inherits from stream.Duplex.
  • Updated express and restify adaptive integrations to support INodeDuplex.
  • Updated BotFrameworkHttpAdapter, CloudAdapter to support INodeDuplex, and avoid casting from Duplex to Socket.
  • Updated WebSockets and NamedPipes to better support INodeSocket type.

Testing

The following image shows how the sample now supports the Duplex type.
imagen

@sw-joelmut sw-joelmut requested a review from a team as a code owner October 15, 2024 12:54
@coveralls
Copy link

coveralls commented Oct 15, 2024

Pull Request Test Coverage Report for Build 11346498083

Details

  • 1 of 3 (33.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.242%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botframework-streaming/src/namedPipe/namedPipeClient.ts 0 2 0.0%
Totals Coverage Status
Change from base Build 11237135309: 0.0%
Covered Lines: 20444
Relevant Lines: 22942

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants