Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port: [#6793][#6792] Composer Bot with QnA Intent recognized triggers duplicate QnA queries #4700

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

JhontSouth
Copy link
Collaborator

#minor

Description

This PR ports the PR # 6793 which fixes the double QnA trace issue.

Specific Changes

  • Updated AdaptiveDialog to avoid reprocessing recognized activities by adding a condition if the recognized event was already processed.
  • Added unit tests to validate the new condition works.

Testing

The following image shows how it just throws one trace by every message.
image

@JhontSouth JhontSouth requested a review from a team as a code owner June 28, 2024 16:04
@coveralls
Copy link

coveralls commented Jun 28, 2024

Pull Request Test Coverage Report for Build 9715640406

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 84.078%

Totals Coverage Status
Change from base Build 9702757048: -0.4%
Covered Lines: 20347
Relevant Lines: 22904

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 28, 2024

Pull Request Test Coverage Report for Build 9715640406

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 84.433%

Totals Coverage Status
Change from base Build 9702757048: 0.002%
Covered Lines: 20429
Relevant Lines: 22904

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit de27db4 into main Jul 1, 2024
12 checks passed
@tracyboehrer tracyboehrer deleted the southworks/fix/qna-double-trace branch July 1, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants