Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [#4636] Add more information to Tenant parameters #4649

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

sw-joelmut
Copy link
Collaborator

Fixes #4636

Description

This PR adds more information to optional Tenant parameters used in authentication classes. Explaining when it's optional or required, and the default when no value is provided.

Specific Changes

  • Add Tenant comment to authentication (AppCredentials, CertificateAppCredentials, MicrosoftAppCredentials, and auth factories) classes.
  • The new comment contains information when required, optional, and the default value. Additionally, a link to the supported Azure app types.

Testing

The following image shows how the new comment looks.
image

@sw-joelmut sw-joelmut requested a review from a team as a code owner April 19, 2024 19:16
@coveralls
Copy link

coveralls commented Apr 19, 2024

Pull Request Test Coverage Report for Build 8758530812

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.431%

Totals Coverage Status
Change from base Build 8706846204: 0.0%
Covered Lines: 20426
Relevant Lines: 22901

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit e008ef0 into main Apr 19, 2024
12 checks passed
@tracyboehrer tracyboehrer deleted the southworks/add/tenant-info branch April 19, 2024 19:35
This was referenced Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CertificateAppCredentials defaults tenant to botframework.com
3 participants