Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#2782] Migrate to MSAL from adal-node - Add MSAL support #4543

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

ceciliaavila
Copy link
Collaborator

#minor
Addresses #2782

Description

This PR adds support for MSAL as the first step to remove ADAL dependency from the repository.
As MSAL supports a limited number of TS versions, we removed support for versions 3.5, 3.6, and 3.7.

Specific Changes

  • Added new class MsalAppCredentials.
  • Added new class MsalServiceClientCredentialsFactory.
  • Updated consumer-test/run.ts to remove old TS versions from the testing matrix.
  • Added TS version >= 3.8 as a pre-requisite in the README file

Testing

These images show a bot working with MSAL using credentials and certificates to authenticate.
image

@ceciliaavila ceciliaavila added the no parity This issue applies only to this platform label Oct 10, 2023
@ceciliaavila ceciliaavila requested a review from a team as a code owner October 10, 2023 12:14
@coveralls
Copy link

coveralls commented Oct 10, 2023

Pull Request Test Coverage Report for Build 6469114986

  • 15 of 46 (32.61%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 84.766%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-dialogs-adaptive-runtime-core/src/serviceCollection.ts 1 2 50.0%
libraries/botframework-connector/src/auth/msalServiceClientCredentialsFactory.ts 4 18 22.22%
libraries/botframework-connector/src/auth/msalAppCredentials.ts 8 24 33.33%
Totals Coverage Status
Change from base Build 6406526914: -0.1%
Covered Lines: 20271
Relevant Lines: 22657

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit fff65b4 into main Oct 10, 2023
13 checks passed
@tracyboehrer tracyboehrer deleted the southworks/add/support-msal branch October 10, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no parity This issue applies only to this platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants