fix: Replace Map with WeakMap to avoid memory leak #4517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5800804749
💛 - Coveralls |
|
Hi @tracyboehrer, this PR contains the changes to use WeakMap instead of Map. |
tracyboehrer
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#minor
Description
This PR replaces the use of Map with WeakMap in the LanguageGeneratorExtensions and ExpressionParser classes due to a memory leak issue reported in a JS Composer bot.
Specific Changes
_languageGeneratorManagerswith WeakMap inLanguageGeneratorExtensions.expressionDictwith WeakMap inExpressionParser. Also, changed the type of the key as WeakMap only supports objects.Testing
The unit tests passed after the changes.
