Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cherrypick orchestrator fix, runtime docs #3845

Merged
merged 2 commits into from
Jul 2, 2021
Merged

Conversation

joshgummersall
Copy link
Contributor

Cherrypick a few more changes for 4.14.

#minor

tsuwandy and others added 2 commits July 2, 2021 09:09
* Update orchestratorRecognizer.ts

fixed bug in initializemodel

* Update orchestratorRecognizer.ts

if load with entity model fail, the no need to fall back to intent only
* port: runtime docs

Fixes #3809

Also adds some types to ServiceCollection calls

* spellcheck!

Co-authored-by: Michael Richardson <40401643+mdrichardson@users.noreply.github.com>

Co-authored-by: Michael Richardson <40401643+mdrichardson@users.noreply.github.com>
@joshgummersall joshgummersall requested review from a team as code owners July 2, 2021 17:28
@joshgummersall joshgummersall changed the title cherrypick: orchestrator fix, runtime docs feat: cherrypick orchestrator fix, runtime docs Jul 2, 2021
@coveralls
Copy link

coveralls commented Jul 2, 2021

Pull Request Test Coverage Report for Build 994378431

  • 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 84.329%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-ai-orchestrator/src/orchestratorRecognizer.ts 0 5 0.0%
Totals Coverage Status
Change from base Build 987759133: -0.005%
Covered Lines: 19629
Relevant Lines: 22079

💛 - Coveralls

@joshgummersall joshgummersall merged commit c4d0d5b into 4.14 Jul 2, 2021
@joshgummersall joshgummersall deleted the jpg/4.14 branch July 2, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants