Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update OrchestratorRecognizer to 4.14.0 orchestrator-core #3818

Merged
merged 6 commits into from
Jun 25, 2021
Merged

fix: Update OrchestratorRecognizer to 4.14.0 orchestrator-core #3818

merged 6 commits into from
Jun 25, 2021

Conversation

tsuwandy
Copy link
Contributor

Fixes #3817

@tsuwandy tsuwandy marked this pull request as draft June 25, 2021 20:48
@tsuwandy tsuwandy requested a review from daveta June 25, 2021 20:48
@joshgummersall
Copy link
Contributor

You'll need to run yarn to update the lock file.

@tsuwandy tsuwandy marked this pull request as ready for review June 25, 2021 21:22
@tsuwandy tsuwandy changed the title Fixes - Update OrchestratorRecognizer to 4.14.0 orchestrator-core fix: Update OrchestratorRecognizer to 4.14.0 orchestrator-core Jun 25, 2021
@joshgummersall
Copy link
Contributor

@tsuwandy you'll need to update all the import and/or require calls in the code as well.

@tsuwandy tsuwandy requested a review from a team as a code owner June 25, 2021 22:16
@joshgummersall joshgummersall merged commit 48606d4 into main Jun 25, 2021
@joshgummersall joshgummersall deleted the tiens-4.14 branch June 25, 2021 23:14
@coveralls
Copy link

coveralls commented Jun 26, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 972857355

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.713%
Totals Coverage Status
Change from base Build 972669558: 0.0%
Covered Lines: 19501
Relevant Lines: 22069
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgummersall joshgummersall joshgummersall approved these changes

@daveta daveta daveta approved these changes

@stevengum stevengum Awaiting requested review from stevengum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Orchestrator recognizer to point at 4.14.0 release
4 participants
@tsuwandy @joshgummersall @coveralls @daveta