Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: AdaptiveExpressions: Allow 0 to convert as false bool #3801

Merged
merged 1 commit into from
Jun 24, 2021
Merged

feat: AdaptiveExpressions: Allow 0 to convert as false bool #3801

merged 1 commit into from
Jun 24, 2021

Conversation

Danieladu
Copy link
Contributor

Fixes #3798

Description

Allow 0 to convert as false bool

@Danieladu Danieladu requested review from a team as code owners June 24, 2021 04:04
@coveralls
Copy link

coveralls commented Jun 24, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 966669573

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 83.796%
Totals Coverage Status
Change from base Build 966315886: 0.07%
Covered Lines: 19496
Relevant Lines: 22041
💛 - Coveralls

@joshgummersall joshgummersall merged commit 9719123 into main Jun 24, 2021
@joshgummersall joshgummersall deleted the hond/number-bool branch June 24, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgummersall joshgummersall joshgummersall approved these changes

@carlosscastro carlosscastro Awaiting requested review from carlosscastro

@mrivera-ms mrivera-ms Awaiting requested review from mrivera-ms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

port: feat: AdaptiveExpressions: Allow 0 to convert as false bool
3 participants
@Danieladu @coveralls @joshgummersall