Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: turn memory scope in snapshot #3775

Merged
merged 1 commit into from
Jun 18, 2021
Merged

port: turn memory scope in snapshot #3775

merged 1 commit into from
Jun 18, 2021

Conversation

joshgummersall
Copy link
Contributor

Fixes #3770

@joshgummersall joshgummersall requested review from a team as code owners June 18, 2021 17:47
@coveralls
Copy link

coveralls commented Jun 18, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 950648411

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.409%
Totals Coverage Status
Change from base Build 950485624: 0.0%
Covered Lines: 19279
Relevant Lines: 21473
💛 - Coveralls

@mdrichardson
Copy link
Contributor

@joshgummersall Holding off on test changes until Auth tests are ported?

@joshgummersall joshgummersall merged commit 1b027b0 into main Jun 18, 2021
@joshgummersall joshgummersall deleted the jpg/port-turn-memory-scope-snapshot branch June 18, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdrichardson mdrichardson mdrichardson approved these changes

@chrimc62 chrimc62 Awaiting requested review from chrimc62

@tomlm tomlm Awaiting requested review from tomlm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

port: flip turn memory scope to be included in the snapshot (#5686)
3 participants
@joshgummersall @coveralls @mdrichardson