Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make enum lookup case insensitive #3743

Merged
merged 2 commits into from
Jun 15, 2021
Merged

Conversation

joshgummersall
Copy link
Contributor

@joshgummersall joshgummersall commented Jun 14, 2021

I tested the HTTP action in Composer with the .NET runtime, and it appears that enum resolution is case insensitive, so this PR replicates that behavior. I tested this by linking against a Composer bot and manually editing the enum value in the dialog to different casing variations.

Fixes https://github.com/microsoft/BotFramework-Composer/issues/7834
Fixes #3744

@coveralls
Copy link

coveralls commented Jun 14, 2021

Pull Request Test Coverage Report for Build 937966284

  • 9 of 10 (90.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.008%) to 85.406%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/adaptive-expressions/src/converters/enumExpressionConverter.ts 9 10 90.0%
Files with Coverage Reduction New Missed Lines %
libraries/adaptive-expressions/src/converters/enumExpressionConverter.ts 1 73.08%
libraries/botbuilder-lg/src/templateExtensions.ts 1 84.48%
Totals Coverage Status
Change from base Build 937811099: -0.008%
Covered Lines: 19273
Relevant Lines: 21467

💛 - Coveralls

@joshgummersall
Copy link
Contributor Author

Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small ask and a suggestion for cleanup. Otherwise LGTM

@joshgummersall joshgummersall merged commit eb2a383 into main Jun 15, 2021
@joshgummersall joshgummersall deleted the jpg/case-insensitive-enums branch June 15, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DialogContextError: DialogStateManager.getValue: a scope of 'json' wasn't found
3 participants