Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: Fix double evaluation and filter sensitive settings #3740

Merged
merged 10 commits into from
Jun 15, 2021
Merged

port: Fix double evaluation and filter sensitive settings #3740

merged 10 commits into from
Jun 15, 2021

Conversation

Danieladu
Copy link
Contributor

Fixes #3735

Description

Fix the double evaluation and filter sensitive settings

@coveralls
Copy link

coveralls commented Jun 11, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 937777786

  • 34 of 36 (94.44%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 85.411%
Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-core/src/activityFactory.ts 1 2 50.0%
libraries/botbuilder-dialogs/src/memory/scopes/settingsMemoryScope.ts 17 18 94.44%
Totals Coverage Status
Change from base Build 936548125: 0.003%
Covered Lines: 19268
Relevant Lines: 21461
💛 - Coveralls

@boydc2014 boydc2014 marked this pull request as ready for review June 12, 2021 04:27
@boydc2014 boydc2014 requested review from a team as code owners June 12, 2021 04:27
joshgummersall
joshgummersall reviewed Jun 14, 2021
View reviewed changes
Copy link
Contributor

@joshgummersall joshgummersall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple quick suggestions, otherwise looks good.

libraries/botbuilder-dialogs/src/memory/scopes/settingsMemoryScope.ts Outdated Show resolved Hide resolved
libraries/botbuilder-dialogs/src/memory/scopes/settingsMemoryScope.ts Show resolved Hide resolved
libraries/botbuilder-dialogs/src/memory/scopes/settingsMemoryScope.ts Outdated Show resolved Hide resolved
@joshgummersall
Copy link
Contributor

@Danieladu I made the quick fixes I suggested so we're good to go.

joshgummersall
joshgummersall previously approved these changes Jun 14, 2021
View reviewed changes
@joshgummersall joshgummersall dismissed their stale review June 15, 2021 01:51

Waiting on resolution for Michael Richardson's comment.

@joshgummersall joshgummersall merged commit 87ecf38 into main Jun 15, 2021
@joshgummersall joshgummersall deleted the hond/data-binding branch June 15, 2021 02:21
@sw-joelmut sw-joelmut mentioned this pull request Feb 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boydc2014 boydc2014 boydc2014 approved these changes

@mdrichardson mdrichardson mdrichardson left review comments

@joshgummersall joshgummersall joshgummersall approved these changes

@Stevenic Stevenic Awaiting requested review from Stevenic

@luhan2017 luhan2017 Awaiting requested review from luhan2017

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

port: Fix double evaluation and filter sensitive settings (#5641)
5 participants
@Danieladu @coveralls @joshgummersall @boydc2014 @mdrichardson