Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unnecessary public access modifier #3731

Merged
merged 3 commits into from
Jun 8, 2021
Merged

Conversation

stevengum
Copy link
Member

Part 1 of #3518
#minor

Description:

Removed public access modifier from following packages:

  • botbuilder-ai-orchestrator
  • botbuilder-ai
  • botbuilder-applicationinsights
  • botbuilder-azure-queues
  • botbuilder-azure

@stevengum stevengum added the Automation: No parity PR does not need to be applied to other languages. label Jun 7, 2021
@stevengum stevengum requested a review from a team as a code owner June 7, 2021 23:43
Copy link
Contributor

@mdrichardson mdrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevengum
Copy link
Member Author

@mdrichardson thanks for providing the rule and link. Adding the rule is one of the completion criteria for the issue, and I'll add it to this PR and other PRs on a package basis and make a note to myself to add it to the root config and cleanup the duplicates once all the packages are cleaned up.

@coveralls
Copy link

coveralls commented Jun 8, 2021

Pull Request Test Coverage Report for Build 916696710

  • 55 of 55 (100.0%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.341%

Totals Coverage Status
Change from base Build 903466753: 0.0%
Covered Lines: 19237
Relevant Lines: 21437

💛 - Coveralls

@stevengum stevengum merged commit e00e6c8 into main Jun 8, 2021
@stevengum stevengum deleted the stgum/3518 branch June 8, 2021 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation: No parity PR does not need to be applied to other languages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants